[libvirt] [PATCH v6 4/8] snapshot: Export two functions prior to file split

Eric Blake eblake at redhat.com
Fri Mar 15 05:02:29 UTC 2019


The next patch will require access to the helper functions
virDomainSnapshotDefFormatInternal and
virDomainSnapshotRedefineValidate from two different files; make the
file split easier by exporting these functions.

Signed-off-by: Eric Blake <eblake at redhat.com>
---
 src/conf/snapshot_conf.h | 13 +++++++++++++
 src/conf/snapshot_conf.c |  4 ++--
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/src/conf/snapshot_conf.h b/src/conf/snapshot_conf.h
index 444de05a71..c816ad06e1 100644
--- a/src/conf/snapshot_conf.h
+++ b/src/conf/snapshot_conf.h
@@ -134,6 +134,13 @@ char *virDomainSnapshotDefFormat(const char *uuidstr,
                                  virCapsPtr caps,
                                  virDomainXMLOptionPtr xmlopt,
                                  unsigned int flags);
+int virDomainSnapshotDefFormatInternal(virBufferPtr buf,
+                                       const char *uuidstr,
+                                       virDomainSnapshotDefPtr def,
+                                       virCapsPtr caps,
+                                       virDomainXMLOptionPtr xmlopt,
+                                       unsigned int flags);
+
 int virDomainSnapshotObjListFormat(virBufferPtr buf,
                                    const char *uuidstr,
                                    virDomainSnapshotObjListPtr snapshots,
@@ -203,6 +210,12 @@ int virDomainSnapshotRedefinePrep(virDomainPtr domain,
                                   bool *update_current,
                                   unsigned int flags);

+int virDomainSnapshotRedefineValidate(virDomainSnapshotDefPtr def,
+                                      const unsigned char *domain_uuid,
+                                      virDomainSnapshotObjPtr other,
+                                      virDomainXMLOptionPtr xmlopt,
+                                      unsigned int flags);
+
 VIR_ENUM_DECL(virDomainSnapshotLocation);
 VIR_ENUM_DECL(virDomainSnapshotState);

diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index 3b0e527bb2..560150977b 100644
--- a/src/conf/snapshot_conf.c
+++ b/src/conf/snapshot_conf.c
@@ -429,7 +429,7 @@ virDomainSnapshotDefParseString(const char *xmlStr,
 /* Perform sanity checking on a redefined snapshot definition. If
  * @other is non-NULL, this may include swapping def->dom from other
  * into def. */
-static int
+int
 virDomainSnapshotRedefineValidate(virDomainSnapshotDefPtr def,
                                   const unsigned char *domain_uuid,
                                   virDomainSnapshotObjPtr other,
@@ -896,7 +896,7 @@ virDomainSnapshotDiskDefFormat(virBufferPtr buf,

 /* Append XML describing def into buf. Return 0 on success, or -1 on
  * failure with buf cleared. */
-static int
+int
 virDomainSnapshotDefFormatInternal(virBufferPtr buf,
                                    const char *uuidstr,
                                    virDomainSnapshotDefPtr def,
-- 
2.20.1




More information about the libvir-list mailing list