[libvirt] [PATCH 1/3] travis: Use 'redhat' init script on CentOS 7

Daniel P. Berrangé berrange at redhat.com
Fri Mar 15 10:26:21 UTC 2019


On Fri, Mar 15, 2019 at 10:23:52AM +0000, Daniel P. Berrangé wrote:
> On Thu, Mar 14, 2019 at 12:31:08PM +0100, Andrea Bolognani wrote:
> > We're gonna drop Upstart support soon, and we don't want
> > Travis CI builds to break when we do.
> > 
> > Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> > ---
> >  .travis.yml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/.travis.yml b/.travis.yml
> > index 55ba340a34..e80f1d367f 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -17,7 +17,7 @@ matrix:
> >          - docker
> >        env:
> >          - IMAGE="centos-7"
> > -        - DISTCHECK_CONFIGURE_FLAGS="--with-init-script=upstart"
> > +        - DISTCHECK_CONFIGURE_FLAGS="--with-init-script=redhat"
> 
> Heh, this was always kind of wrong since RHEL 6 was the one
> with upstart
> 
> Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

Actually on second thoughts, this is not desirable.

We should be actually purging the traditional init script too. RHEL-7
is systemd based and so are all Fedora's.  The "redhat" initscript
was last used in RHEL-6. Even if other distros use classis sysvinit
I don't think they'll  use the Red Hat variant initscript.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list