[libvirt] [PATCH] run: Don't export unnecessary paths

Daniel P. Berrangé berrange at redhat.com
Fri Mar 15 10:28:43 UTC 2019


On Thu, Mar 14, 2019 at 10:19:17AM +0100, Andrea Bolognani wrote:
> We're using virFileFindResourceFull() to locate resources
> nowadays, which makes exporting these information in the
> environment unnecessary: see
> 
>   virDriverLoadModule() for LIBVIRT_DRIVER_DIR
>   virLockManagerPluginNew() for LIBVIRT_LOCK_MANAGER_PLUGIN_DIR
>   virLockManagerLockDaemonConnectionNew() for VIRTLOCKD_PATH
>   doRemoteOpen() for LIBVIRTD_PATH
> 
> As further proof that we don't need to expose the information
> this way anymore, we're not even exporting VIRTLOGD_PATH, which
> would be necessary if virLogManagerConnect() didn't already
> take care of that for us.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  run.in | 5 -----
>  1 file changed, 5 deletions(-)

Yep, most of "run" dates from before we tried to automatically
"do the right thing".

For running anything in libvirt the "run" script isn't really
needed at all, except for making running commands like gdb
less verbose.

The main usefulness of "run" is for building language bindings
via a pkg-config

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list