[libvirt] [PATCH v2 1/3] conf: don't use "class" as name in _virNodeDevCapPCIDev

[Daniel P. Berrangé]

On Tue, Mar 12, 2019 at 02:14:39PM +0300, Nikolay Shirokovskiy wrote:
> Vim treats *.h files as cpp ones with respect to syntax highlighting.

Surprised it doesn't use .hpp for C++ headers, but no matter.

> Thus "class" in _virNodeDevCapPCIDev highlighted mistakenly.
> This can be fixed by filetype detection code tunables but it
> is more convinient to skip this tuning by every project member.
> 
> Let's just use "klass" as field name instead of _class or class
> and add syntax rule.

I think that's good practice regardless of the vimm issue !

> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
> ---
>  cfg.mk                             | 8 ++++++++
>  src/conf/node_device_conf.c        | 4 ++--
>  src/conf/node_device_conf.h        | 4 ++--
>  src/node_device/node_device_udev.c | 4 ++--
>  4 files changed, 14 insertions(+), 6 deletions(-)
> 
> diff --git a/cfg.mk b/cfg.mk
> index f99b8ae631..88198037cc 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -1075,6 +1075,14 @@ sc_require_attribute_cleanup_initialization:
>  	halt='variable declared with a cleanup macro must be initialized' \
>  	  $(_sc_search_regexp)
>  
> +# "class" in headers is not good because by default Vim treats it as a keyword
> +sc_prohibit_class_in_headers:
> +	@prohibit=' +_?class *;' \
> +	in_vc_files='\.h$$' \

How about extending that rule to '.c' too. The .h check will cause
most of the usage in .c files to be removed anyway, so might as well
blacklist it explicitly in .c

> +	halt='use klass instead of class or _class as name in header files' \
> +	  $(_sc_search_regexp)
> +
> +
>  # We don't use this feature of maint.mk.
>  prev_version_file = /dev/null

With or without the .c blacklist too

  Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|