[libvirt] [PATCH] virQEMUDriverPtr clean up
Peter Krempa
pkrempa at redhat.com
Mon Mar 18 10:28:33 UTC 2019
On Sun, Mar 17, 2019 at 06:04:27 +0000, Humaid wrote:
> From: Ubuntu <shbh at Ubuntu1.4obxdks5shaudmr0jmg1ainqgb.bx.internal.cloudapp.net>
This address is not resolvable your git is probably misconfigured.
Please provide a commit message according to the contributor
guildelines including certification of agreement with the developer
certificate of origin.
https://libvirt.org/hacking.html#patches
>
> ---
> src/qemu/qemu_tpm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c
> index 835a9caf46..b60e443f14 100644
> --- a/src/qemu/qemu_tpm.c
> +++ b/src/qemu/qemu_tpm.c
> @@ -834,16 +834,16 @@ qemuExtTPMStartEmulator(virQEMUDriverPtr driver,
>
>
> int
> -qemuExtTPMStart(virQEMUDriverPtr driver,
> - virDomainObjPtr vm,
> +qemuExtTPMStart(virDomainObjPtr vm,
> qemuDomainLogContextPtr logCtxt)
This does not fix any of the callers nor the header file thus breaks the
build.
Additionally without any further refactors and no justification
in the commit message I don't see much value in this change. Please
write a commit message and justify it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190318/91baf214/attachment-0001.sig>
More information about the libvir-list
mailing list