[libvirt] [PATCH 01/21] qemu: add virQEMUCapsSetVList

Andrea Bolognani abologna at redhat.com
Tue Mar 19 09:51:59 UTC 2019


On Thu, 2019-03-14 at 10:43 -0400, Cole Robinson wrote:
> It will be used in future patches

You're actually changing the existing virQEMUCapsSetList() to use
it... I'd point that out in the commit message. You can still
mention the fact that you're going to add more users later on.

[...]
>  void
> +virQEMUCapsSetVList(virQEMUCapsPtr qemuCaps, va_list list)

I'd call this virQEMUCapsSetVAList(), given the type of the second
argument; the existing virCommandNewVAList() already uses this naming
scheme.

The second argument should be on a separate line.


Everything else looks good, so

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list