[libvirt] [PATCH v3 03/36] conf: simplify link from hostdev back to network device

Cole Robinson crobinso at redhat.com
Fri Mar 22 00:50:56 UTC 2019


On 3/19/19 8:46 AM, Daniel P. Berrangé wrote:
> hostdevs have a link back to the original network device. This is fairly
> generic accepting any type of device, however, we don't intend to make
> use of this approach in future. It can thus be specialized to network
> devices.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  src/conf/domain_conf.c         | 18 ++++++++----------
>  src/conf/domain_conf.h         |  8 +++++++-
>  src/libxl/libxl_driver.c       |  4 ++--
>  src/network/bridge_driver.c    |  3 +--
>  src/qemu/qemu_command.c        |  3 +--
>  src/qemu/qemu_domain_address.c |  4 ++--
>  src/qemu/qemu_driver.c         |  2 +-
>  src/qemu/qemu_hotplug.c        | 14 ++++++--------
>  src/qemu/qemu_hotplug.h        |  2 +-
>  src/util/virhostdev.c          | 17 ++++++++---------
>  10 files changed, 37 insertions(+), 38 deletions(-)
> 

If it doesn't cause too many conflicts I'd say rename it to parentnet
while you're at it. If not it could be a follow up change, parent is
just too generic sounding in this case

Reviewed-by: Cole Robinson <crobinso at redhat.com>

And it could go in now IMO

- Cole




More information about the libvir-list mailing list