[libvirt] [PATCH v3 04/36] network: add missing bandwidth limits for bridge forward type
Cole Robinson
crobinso at redhat.com
Fri Mar 22 00:58:27 UTC 2019
On 3/19/19 8:46 AM, Daniel P. Berrangé wrote:
> In the case of a network with forward=bridge, which has a bridge device
> listed, we are capable of setting bandwidth limits but fail to call the
> function to register them.
>
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
> src/network/bridge_driver.c | 39 ++++++++++++++++++++++++++-----------
> 1 file changed, 28 insertions(+), 11 deletions(-)
>
One thing missing is class_id XML reading in
virDomainActualNetDefParseXML, that needs to be adjusted for TYPE_BRIDGE
With that, code wise I'll give:
Reviewed-by: Cole Robinson <crobinso at redhat.com>
but I can't really comment on if there's any hidden pitfalls. But I'd
say push it and we can figure it out in git master
- Cole
More information about the libvir-list
mailing list