[libvirt] [PATCH 15/16] snapshot: Tweaks to support new bulk dumpxml/import API
Eric Blake
eblake at redhat.com
Fri Mar 22 06:01:17 UTC 2019
On 3/21/19 7:41 PM, John Ferlan wrote:
>
>
> On 3/20/19 1:41 AM, Eric Blake wrote:
>> Change the return value of virDomainSnapshotObjLisParse() to return
>
> *ListParse
>
>> the number of snapshots imported, and allow a return of 0 (the
>> original proposal of adding a flag to virDomainSnapshotCreateXML
>> required returning an arbitrary non-NULL snapshot, but with a new API
>> that returns a count, we are no longer constrained to a non-empty
>> list).
>>
>> Document which flags are supported (namely, just SECURE) in
>> virDomainSnapshotObjListFormat().
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>> src/conf/virdomainsnapshotobjlist.c | 19 +++++++++----------
>> 1 file changed, 9 insertions(+), 10 deletions(-)
>>
>
> Perhaps 2 separate patches since I don't think they're related.
I kept it as one, but retitled the patch and shifted it earlier in the
series before pushing it.
>
> Reviewed-by: John Ferlan <jferlan at redhat.com>
>
> John
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190322/cd188783/attachment-0001.sig>
More information about the libvir-list
mailing list