[libvirt] [PATCH v2 2/4] tests: qemuxml2argv: move DO_CAPS_TEST* qemuCaps init

[Andrea Bolognani]

On Thu, 2019-03-21 at 15:55 -0400, Cole Robinson wrote:
[...]
> +        if (!(qemuCaps = qemuTestParseCapabilitiesArch(virArchFromString(capsarch),
> +                                                       capsfile)))
> +            goto cleanup;

I'd put curly brackets around the body here.

[...]
> +        if (testInfoSetArgs(&info, capslatest, \
> +                            ARG_CAPS_ARCH, arch, \
> +                            ARG_CAPS_VER, ver, \
> +                            __VA_ARGS__, ARG_END) < 0) \

I'd put ARG_END on its own line both here...

[...]
> +        if (testInfoSetArgs(&info, capslatest, \
> +                            __VA_ARGS__, QEMU_CAPS_LAST, ARG_END) < 0) \

... and here.


Regardless of whether or not you decide to make those tweaks,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization