[libvirt] [PATCH 09/21] qemu_hotplug: merge qemuDomainDetachThisHostDevice into qemuDomainDetachHostDevice

Peter Krempa pkrempa at redhat.com
Fri Mar 22 09:32:40 UTC 2019


On Thu, Mar 21, 2019 at 18:28:49 -0400, Laine Stump wrote:
> It's now only called from one place, and combining the two functions
> highlights the similarity with Detach functions for other device
> types.
> 
> Signed-off-by: Laine Stump <laine at laine.org>
> ---
>  src/qemu/qemu_hotplug.c | 107 +++++++++++++++-------------------------
>  1 file changed, 41 insertions(+), 66 deletions(-)

ACK, this does what it says. There are a few things that could be done
better though e.g. assigning an alias via qemuAssignDeviceHostdevAlias
makes the chechk whether it's assigned dead code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190322/387df1da/attachment-0001.sig>


More information about the libvir-list mailing list