[libvirt] [PATCH 02/21] qemu_hotplug: remove another erroneous qemuDomainDetachExtensionDevice() call

[Ján Tomko]

On Thu, Mar 21, 2019 at 06:28:42PM -0400, Laine Stump wrote:
>qemuDomainRemoveRNGDevice() calls qemuDomainDetachExtensionDevice().
>According to commit 1d1e264f1 that added this code, it should not be
>necessary to explicitly remove the zPCI extension device for a PCI
>device during unplug, because "QEMU implements an unplug callback
>which will unplug both PCI and zPCI device in a cascaded way". In
>fact, no other devices call qemuDomainDetachExtensionDevice() during
>their qemuDomainRemove*Device() function, so it should be removed from
>qemuDomainRemoveRNGDevice as well.
>
>Signed-off-by: Laine Stump <laine at laine.org>
>---
> src/qemu/qemu_hotplug.c | 3 ---
> 1 file changed, 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190322/77c76068/attachment-0001.sig>