[libvirt] [PATCH 09/21] qemu_hotplug: merge qemuDomainDetachThisHostDevice into qemuDomainDetachHostDevice

Laine Stump laine at laine.org
Fri Mar 22 13:25:02 UTC 2019


On 3/22/19 5:32 AM, Peter Krempa wrote:
> On Thu, Mar 21, 2019 at 18:28:49 -0400, Laine Stump wrote:
>> It's now only called from one place, and combining the two functions
>> highlights the similarity with Detach functions for other device
>> types.
>>
>> Signed-off-by: Laine Stump <laine at laine.org>
>> ---
>>   src/qemu/qemu_hotplug.c | 107 +++++++++++++++-------------------------
>>   1 file changed, 41 insertions(+), 66 deletions(-)
> ACK, this does what it says. There are a few things that could be done
> better though e.g. assigning an alias via qemuAssignDeviceHostdevAlias
> makes the chechk whether it's assigned dead code.


Yeah, it goes away later. I wanted to keep this patch to only code 
movement as much as possible.




More information about the libvir-list mailing list