[libvirt] [PATCH] virQEMUDriverPtr parameters clean up in function qemuExtTPMStart() in /src/qemu/qemu_tpm.c

Erik Skultety eskultet at redhat.com
Mon Mar 25 08:14:38 UTC 2019


You're missing:
- commit message explaining the change
- Your full name as author
- compliance with developer certificate of origin, see [1]

On Sat, Mar 23, 2019 at 08:34:42PM +0400, Humaid wrote:
> ---
>  src/qemu/qemu_tpm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c
> index 835a9caf46..b60e443f14 100644
> --- a/src/qemu/qemu_tpm.c
> +++ b/src/qemu/qemu_tpm.c
> @@ -834,16 +834,16 @@ qemuExtTPMStartEmulator(virQEMUDriverPtr driver,
>
>
>  int
> -qemuExtTPMStart(virQEMUDriverPtr driver,
> -                virDomainObjPtr vm,
> +qemuExtTPMStart(virDomainObjPtr vm,
>                  qemuDomainLogContextPtr logCtxt)
>  {
>      int ret = 0;
> +    qemuDomainObjPrivatePtr priv = vm->privateData;

A quick grep through the code base shows that we could do this at many more
places actually.

Regards,
Erik




More information about the libvir-list mailing list