[libvirt] [PATCH] virQEMUDriverPtr parameters clean up in function qemuExtTPMStart() in /src/qemu/qemu_tpm.c

[Ján Tomko]

On Sat, Mar 23, 2019 at 08:34:42PM +0400, Humaid wrote:
>---
> src/qemu/qemu_tpm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c
>index 835a9caf46..b60e443f14 100644
>--- a/src/qemu/qemu_tpm.c
>+++ b/src/qemu/qemu_tpm.c
>@@ -834,16 +834,16 @@ qemuExtTPMStartEmulator(virQEMUDriverPtr driver,
>
>
> int
>-qemuExtTPMStart(virQEMUDriverPtr driver,
>-                virDomainObjPtr vm,
>+qemuExtTPMStart(virDomainObjPtr vm,
>                 qemuDomainLogContextPtr logCtxt)

This is not a static function, so you also need to change its prototype
in the header file to get this to compile.

> {
>     int ret = 0;
>+    qemuDomainObjPrivatePtr priv = vm->privateData;
>     virDomainTPMDefPtr tpm = vm->def->tpm;
>
>     switch (tpm->type) {
>     case VIR_DOMAIN_TPM_TYPE_EMULATOR:
>-        ret = qemuExtTPMStartEmulator(driver, vm, logCtxt);
>+        ret = qemuExtTPMStartEmulator(priv->driver, vm, logCtxt);

It's not necessary to pass 'driver' to qemuExtTPMStartEmulator either
since we're already passing 'vm'.

Jano

>         break;
>     case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
>     case VIR_DOMAIN_TPM_TYPE_LAST:
>-- 
>2.17.1
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190325/7655b9d8/attachment-0001.sig>