[libvirt] [PATCH v2 14/14] qemu_hotplug: don't shutdown net device until the guest has released it

Peter Krempa pkrempa at redhat.com
Tue Mar 26 13:11:10 UTC 2019


On Mon, Mar 25, 2019 at 13:24:36 -0400, Laine Stump wrote:
> For [some unknown reason, possibly/probably pure chance], Net devices
> have been taken offline and their bandwidth tc rules cleared as the
> very first operation when detaching the device. This is contrary to
> every other type of device, where all hostside teardown is delayed
> until we receive the DEVICE_DELETED event back from qemu, indicating
> that the guest has finished with the device.
> 
> This patch delays these two operations until receipt of
> DEVICE_DELETED, which removes an ugly wart from
> qemuDomainDetachDeviceLive(), and also seems to be a more correct
> sequence of events.
> 
> Signed-off-by: Laine Stump <laine at laine.org>
> ---
> 
> NEW PATCH IN V2.

Looks good to me although I don't have much knowledge in this regions.

Michal, could you please have a look?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190326/05543b98/attachment-0001.sig>


More information about the libvir-list mailing list