[libvirt] [PATCH v3 2/2] m4: Add warning when running QEMU as root

Andrea Bolognani abologna at redhat.com
Tue Mar 26 17:01:49 UTC 2019


Running QEMU as root is a pretty bad idea, so try to make the
user aware of that as part of the configure summary.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 m4/virt-driver-qemu.m4 | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4
index 385d5307a9..eeb96f6ee5 100644
--- a/m4/virt-driver-qemu.m4
+++ b/m4/virt-driver-qemu.m4
@@ -112,5 +112,10 @@ AC_DEFUN([LIBVIRT_DRIVER_RESULT_QEMU], [
 ])
 
 AC_DEFUN([LIBVIRT_RESULT_QEMU_PRIVILEGES], [
-  LIBVIRT_RESULT([QEMU], [$QEMU_USER:$QEMU_GROUP])
+  if test "$QEMU_USER" = "root"; then
+    LIBVIRT_RESULT([QEMU], [$QEMU_USER:$QEMU_GROUP],
+                   [!!! running QEMU as root is strongly discouraged !!!])
+  else
+    LIBVIRT_RESULT([QEMU], [$QEMU_USER:$QEMU_GROUP])
+  fi
 ])
-- 
2.20.1




More information about the libvir-list mailing list