[libvirt] [PATCH v2 1/2] qemu: Fix "boolen" typo in API doc

[Ján Tomko]

Please use --cover-letter for series with two or more patches for neater
alignment of e-mails.

On Wed, Mar 27, 2019 at 12:21:24PM +0100, Christophe Fergeau wrote:
>This also adjusts the argument name which should be 'isListen' in both
>cases rather than 'listen'.
>
>Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
>---
>Changes since v1:
>- really fix 'boolen' typo
>
> src/qemu/qemu_command.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>index f81d20e5f7..82675c5d4e 100644
>--- a/src/qemu/qemu_command.c
>+++ b/src/qemu/qemu_command.c
>@@ -876,7 +876,7 @@ qemuBuildRBDSecinfoURI(virBufferPtr buf,
>
> /* qemuBuildTLSx509BackendProps:
>  * @tlspath: path to the TLS credentials
>- * @listen: boolen listen for client or server setting
>+ * @isListen: boolean listen for client or server setting

Both the rename and the typo fix could be qualified as trivial.
However the description does not make much sense to me.

>  * @verifypeer: boolean to enable peer verification (form of authorization)

peer verification is also used for authentication, as of
commit 441d3eb6d1be940a67ce45a286602a967601b157 (tag: CVE-2017-1000256)

Jano

>  * @alias: alias for the TLS credentials object
>  * @secalias: if one exists, the alias of the security object for passwordid
>@@ -917,7 +917,7 @@ qemuBuildTLSx509BackendProps(const char *tlspath,
> /* qemuBuildTLSx509CommandLine:
>  * @cmd: Pointer to command
>  * @tlspath: path to the TLS credentials
>- * @listen: boolen listen for client or server setting
>+ * @isListen: boolean listen for client or server setting
>  * @verifypeer: boolean to enable peer verification (form of authorization)
>  * @certEncSecretAlias: alias of a 'secret' object for decrypting TLS private key
>  *                      (optional)
>-- 
>2.21.0
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190327/bd0d1116/attachment-0001.sig>