[libvirt] [PATCH v7 18/23] backup: qemu: Implement metadata tracking for checkpoint APIs

[Ján Tomko]

On Wed, Mar 27, 2019 at 05:10:49AM -0500, Eric Blake wrote:
>A lot of this work heavily copies from the existing snapshot
>APIs.  The interaction with qemu during create/delete still
>needs to be implemented, but this takes care of all the libvirt
>metadata (saving and restoring XML, and tracking the relations
>between multiple checkpoints).
>
>Signed-off-by: Eric Blake <eblake at redhat.com>
>---
> src/qemu/qemu_block.h  |   3 +
> src/qemu/qemu_conf.h   |   2 +
> src/qemu/qemu_domain.h |  15 +
> src/qemu/qemu_block.c  |  12 +
> src/qemu/qemu_conf.c   |   5 +
> src/qemu/qemu_domain.c | 133 +++++++
> src/qemu/qemu_driver.c | 843 +++++++++++++++++++++++++++++++++++++++++
> 7 files changed, 1013 insertions(+)
>

>@@ -16932,6 +17747,16 @@ static virDomainPtr qemuDomainQemuAttach(virConnectPtr conn,
>         goto cleanup;
>     }
>
>+    if (qemuProcessAttach(conn, driver, vm, pid,
>+                          pidfile, monConfig, monJSON) < 0) {
>+        monConfig = NULL;
>+        qemuDomainRemoveInactive(driver, vm);
>+        qemuDomainObjEndJob(driver, vm);
>+        goto cleanup;
>+    }
>+
>+    monConfig = NULL;
>+
>     if (qemuProcessAttach(conn, driver, vm, pid,
>                           pidfile, monConfig, monJSON) < 0) {
>         qemuDomainRemoveInactive(driver, vm);

This looks like an artifact after a rebase

Jano

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190327/230a60d2/attachment-0001.sig>