[libvirt] [PATCH v7 06/23] backup: Introduce virDomainCheckpoint APIs

[Eric Blake]

On 3/27/19 6:16 AM, Daniel P. Berrangé wrote:
> On Wed, Mar 27, 2019 at 05:10:37AM -0500, Eric Blake wrote:
>> Introduce a bunch of new public APIs related to backup checkpoints.
>> Checkpoints are modeled heavily after virDomainSnapshotPtr (both
>> represent a point in time of the guest), although a snapshot exists
>> with the intent of rolling back to that state, while a checkpoint
>> exists to make it possible to create an incremental backup at a later
>> time.
>>

>> Operate on a domain object to list all children:
>> virDomainSnapshotNum                (no counterpart, this is the old
>> virDomainSnapshotListNames           racy interface)
>> virDomainSnapshotListAllSnapshots   virDomainListCheckpoints
> 
> s/virDomainListCheckpoints/virDomainListAllCheckpoints/

I was so busy fixing it in the code, I forgot the commit message.


> With the commit message fixed
> 
> Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

We have a positive review on the API, but the implementation is still
rather rough. Is there any consensus on whether the APIs should make it
into 5.2, or do I slip the rest of this series into 5.3?  (The decision
may be made for me, if DV cuts the -rc to start the freeze...)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190327/f7c682c7/attachment-0001.sig>