[libvirt] [PATCH v2 2/2] qemuxml2argvtest: Drop dependency between testInfoArgName and virQEMUCapsFlags enums

Daniel P. Berrangé berrange at redhat.com
Wed Mar 27 17:02:08 UTC 2019


On Wed, Mar 27, 2019 at 05:50:46PM +0100, Michal Privoznik wrote:
> Introduced in fdf6c89ee7b, this dependency looks weird. It was
> needed because of the way that while() loop was written - it
> fetches next argument in every iteration. Therefore, our only
> option was for ARG_END to have the same value as QEMU_CAPS_LAST.
> This also meant that QEMU_CAPS_* could have been only at the end
> of the __VA_ARGS__.
> 
> This commit reworks the while() loop and removes the dependency.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tests/qemuxml2argvtest.c | 35 +++++++++++++++++++++--------------
>  1 file changed, 21 insertions(+), 14 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list