[libvirt] [PATCH 6/6] qemu: caps: Remove pointless debug message in virQEMUCapsInitQMPMonitor

Peter Krempa pkrempa at redhat.com
Fri Mar 29 12:26:34 UTC 2019


Failure of qemuMonitorGetVersion is fatal now that we only support QMP
based qemus. Remove the debug message since we report an error already.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_capabilities.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 2127cfb85c..eb91295f93 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -4325,13 +4325,8 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,

     /* @mon is supposed to be locked by callee */

-    if (qemuMonitorGetVersion(mon,
-                              &major, &minor, &micro,
-                              &package) < 0) {
-        VIR_DEBUG("Failed to query monitor version %s",
-                  virGetLastErrorMessage());
+    if (qemuMonitorGetVersion(mon, &major, &minor, &micro, &package) < 0)
         return -1;
-    }

     VIR_DEBUG("Got version %d.%d.%d (%s)",
               major, minor, micro, NULLSTR(package));
-- 
2.20.1




More information about the libvir-list mailing list