[libvirt] [PATCH 6/7] qemu: monitor: Remove few debug statements

Peter Krempa pkrempa at redhat.com
Fri Mar 29 13:33:43 UTC 2019


The internal qemu machinery already logs the sent message via the PROBE
point in qemuMonitorSend and the monitor receive function. Those are way
better as they are easy grepable. Remove the additional ones from the
monitor code which just duplicate the sent data.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_monitor_json.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 743a88b914..c7a7e3fa56 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -301,14 +301,8 @@ qemuMonitorJSONCommandWithFd(qemuMonitorPtr mon,
     msg.txLength = strlen(msg.txBuffer);
     msg.txFD = scm_fd;

-    VIR_DEBUG("Send command '%s' for write with FD %d", cmdstr, scm_fd);
-
     ret = qemuMonitorSend(mon, &msg);

-    VIR_DEBUG("Receive command reply ret=%d rxObject=%p",
-              ret, msg.rxObject);
-
-
     if (ret == 0) {
         if (!msg.rxObject) {
             virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-- 
2.20.1




More information about the libvir-list mailing list