[libvirt] [PATCH 2/3] virbuffer: Use signed integer for storing error
Michal Privoznik
mprivozn at redhat.com
Fri May 3 09:18:07 UTC 2019
On 5/3/19 10:30 AM, Erik Skultety wrote:
> On Thu, Apr 18, 2019 at 02:11:24PM +0200, Michal Privoznik wrote:
>> The @error member can contain a positive value (errno) or a
>> negative value (-1) to denote an usage error. It doesn't make
>
> s/an usage/a usage
>
> --> even though there are 2 vowels in a row, pronounciation is important, since
> you pronounce it as [ˈjuːzɪʤ], you need 'a' rather than 'an'. An opposite
> example would be 'a hour' vs 'an hour' where the latter is correct because of
> the vowel sound in pronouncing 'hour'.
https://en.wikipedia.org/wiki/Ghoti
>
>> much sense to store it as unsigned then.
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
> trivial
>
> Reviewed-by: Erik Skultety <eskultet at redhat.com>
>
Thanks,
Michal
More information about the libvir-list
mailing list