[libvirt] [PATCH 1/4] tests: Add capabilities for QEMU 3.1.0 on s390x

[Andrea Bolognani]

On Mon, 2019-05-06 at 13:23 +0200, Boris Fiuczynski wrote:
> On 5/3/19 1:04 PM, Andrea Bolognani wrote:
> > As for the patch itself: while it looks fine, personally I don't
> > feel we need to have capabilities for every single QEMU version on
> > every single architecture, so considering that you're adding 4.0.0
> > in the same series and there aren't any 3.1.0-specific tests, I
> > would say let's just skip this one version and add capabilitie for
> > 4.0.0 only. Does that sound reasonable?
> 
> In general I kind of disagree because if the s390x capabilities for 
> every qemu version would have exited the commits e8c2c8bd078 and 
> a1dce96236f mentioned would not have missed the changes in the s390x 
> related args files. In this case it is already history and therefor 
> skipping 3.1.0 by moving the *.args files from the 3.1.0 patch 1 into 3 
> and removing patch 2 feels OK.

Alright, I'll review patches 3 and 4 with this in mind then.

-- 
Andrea Bolognani / Red Hat / Virtualization