[libvirt] [PATCHv2] build: restore support for libyajl 2.0.1

[Jim Fehlig]

On 5/9/19 9:18 AM, Andrea Bolognani wrote:
> On Thu, 2019-05-09 at 16:07 +0200, Ján Tomko wrote:
>> Commit 105756660f944e7db02de3b55b98bb7c11cd03bf was too eager and did
>> not consider SLE 12 which still has 2.0.1 that does not ship
> 
> "SLE" is no longer a thing, so either
> 
>    s/SLE/SUSE Linux Enterprise Server/
> 
> (preferred) or
> 
>    s/SLE/SLES/
> 
> [...]
>> +  PKG_CHECK_EXISTS([readline], [use_pkgconfig=1], [use_pkgconfig=0])
>> +
>> +  if test $use_pkgconfig = 1; then
>> +    dnl 2.0.3 was the version where the pkg-config file was first added
>> +    LIBVIRT_CHECK_PKG([YAJL], [yajl], [2.0.3])
>> +  else
>> +    dnl SUSE SLE 12 and OpenSUSE Leap 42.3 still use 2.0.1
> 
> "SUSE SLE" was never a thing, so either
> 
>    s/SUSE SLE/SUSE Linux Enterprise Server/

That's a lot of typing :-). I think SLES is fine. And to be super pedantic, 
s/OpenSUSE/openSUSE/.

Regards,
Jim

> 
> (preferred) or
> 
>    s/SUSE SLE/SLES/
> 
>> +    dnl TODO: delete this in July 2020
>> +    LIBVIRT_CHECK_LIB([YAJL], [yajl],
>> +                      [yajl_tree_parse], [yajl/yajl_common.h])
>> +
>> +  fi
>> +
> 
> Please drop the empty lines right before and right after the 'if'.
> 
> With the above nits addressed,
> 
>    Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>