[libvirt] [PATCH] virt-aa-helper: clean old reference to libvirt-sandbox

Daniel P. Berrangé berrange at redhat.com
Thu May 16 07:41:53 UTC 2019


On Thu, May 16, 2019 at 09:38:55AM +0200, Christian Ehrhardt wrote:
> It came up that libvirt-sandbox is a failed (and removed) experiment.
> Let us clean up and remove it from the virt-aa-helper source as well.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
> ---
>  src/security/virt-aa-helper.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
> index ad9a7dda94..fea4da80dc 100644
> --- a/src/security/virt-aa-helper.c
> +++ b/src/security/virt-aa-helper.c
> @@ -511,8 +511,7 @@ valid_path(const char *path, const bool readonly)
>      /* override the above with these */
>      const char * const override[] = {
>          "/sys/devices/pci",                /* for hostdev pci devices */
> -        "/sys/kernel/config/target/vhost", /* for hostdev vhost_scsi devices */
> -        "/etc/libvirt-sandbox/services/"   /* for virt-sandbox service config */
> +        "/sys/kernel/config/target/vhost"  /* for hostdev vhost_scsi devices */
>      };

If I'm nitpicking, my preference is to always have a redundant trailing ","
so that changes only have a 1 line diff, as it is harmless in C.

  Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list