[libvirt] [PATCH 1/6] qemu: Introduce virQEMUCapsProbeQMPMachineProps()
Pavel Hrdina
phrdina at redhat.com
Fri May 17 11:32:23 UTC 2019
On Thu, May 16, 2019 at 05:35:31PM +0200, Andrea Bolognani wrote:
> Up until now we've probed machine type properties, along with
> properties for other types, in virQEMUCapsProbeQMPDevices(), but
> soon we're going to need some logic that is specific to machine
> types and as such wouldn't quite fit into that function.
>
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
> src/qemu/qemu_capabilities.c | 52 ++++++++++++++++++++++++++++++------
> 1 file changed, 44 insertions(+), 8 deletions(-)
[...]
> +static int
> +virQEMUCapsProbeQMPMachineProps(virQEMUCapsPtr qemuCaps,
> + qemuMonitorPtr mon)
> +{
> + char **values;
> + int nvalues;
> + size_t i;
> +
> + /* We need qom-list-properties for this to work */
Useless comment, the code says the same thing.
> + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_QOM_LIST_PROPERTIES))
> + return 0;
Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190517/742da8d9/attachment-0001.sig>
More information about the libvir-list
mailing list