[libvirt] [PATCH 1/4] virWaitForDevices: Drop untrue part of comment
Ján Tomko
jtomko at redhat.com
Fri May 17 12:02:53 UTC 2019
On Fri, May 17, 2019 at 11:54:14AM +0200, Michal Privoznik wrote:
>It's not true that there is a backup loop. There isn't. Drop this
There is one in nodeDeviceFindNewDevice. So:
s/untrue/confusing/
>part of the comment to not confuse anybody.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/util/virutil.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/src/util/virutil.c b/src/util/virutil.c
>index e5917d33de..6123741756 100644
>--- a/src/util/virutil.c
>+++ b/src/util/virutil.c
>@@ -1495,8 +1495,6 @@ void virWaitForDevices(void)
> /*
> * NOTE: we ignore errors here; this is just to make sure that any device
> * nodes that are being created finish before we try to scan them.
>- * If this fails for any reason, we still have the backup of polling for
>- * 5 seconds for device nodes.
Documenting what the callers do here in this helper seems strange.
Reviewed-by: Ján Tomko <jtomko at redhat.com>
Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190517/54e43c43/attachment-0001.sig>
More information about the libvir-list
mailing list