[libvirt] [PATCH] i18n: simplify mini po generation

[Daniel P. Berrangé]

On Sat, May 18, 2019 at 10:56:01AM -0500, Marty E. Plummer wrote:
> If you pass --for-msgfmt to msgmerge it will automatically do most of
> what you had the perl script doing.

What msgmerge are you using as that option doesn't exist on Fedora 30
at least ?

  $ msgmerge --for-msgfmt --sort-output uk.po uk.mini.po
  msgmerge: unrecognized option '--for-msgfmt'
  Try 'msgmerge --help' for more information.

  $ rpm -qf /usr/bin/msgmerge 
  gettext-0.19.8.1-18.fc30.x86_64


> 
> Signed-off-by: Marty E. Plummer <hanetzer at startmail.com>
> ---
> The only downside I can see is the loss of the comment headers with the
> copyright year and such. A global note in the README.md or so may be an
> acceptable change.

Removal of copyright strings is a no-go, as that is a violation of
licensing terms unless it is your own copyright notice you are
removing.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|