[libvirt] [PATCH 2/2] Introduce DOMAIN_DEVICE_ITERATE_MISSING_INFO

Ján Tomko jtomko at redhat.com
Thu May 23 12:44:37 UTC 2019


On Wed, May 22, 2019 at 05:22:42PM +0200, Andrea Bolognani wrote:
>On Tue, 2019-05-21 at 16:26 +0200, Ján Tomko wrote:
>> Rename the DOMAIN_DEVICE_ITERATE_GRAPHICS flag.
>> It was introduced by commit dd45c2710f6fd2d4f8a47f97960532d0e0091e7d
>> with the intention to run the Validate callback even on the graphics
>> device.
>>
>> However, enumerating every single device in virDomainDeviceIterateFlags
>> is unsustainable and what really was special about the graphics device
>> was the lack of DeviceInfo.
>>
>> Rename the flag and iterate over more info-less devices. (and leases)
>>
>> Signed-off-by: Ján Tomko <jtomko at redhat.com>
>> Inspired-by: Andrea Bolognani <abologna at redhat.com>
>
>I very clearly voiced my disagreement with this approach, so please
>drop this tag before pushing.
>

Done.

>ACK
>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190523/b111e007/attachment-0001.sig>


More information about the libvir-list mailing list