[libvirt] [PATCH] spec: Fix permissions of nwfilter XMLs

Andrea Bolognani abologna at redhat.com
Mon May 27 10:09:09 UTC 2019


On Thu, 2019-05-23 at 16:35 +0200, Jiri Denemark wrote:
> On Thu, May 23, 2019 at 16:12:27 +0200, Andrea Bolognani wrote:
> > On Thu, 2019-05-23 at 14:56 +0200, Jiri Denemark wrote:
> > [...]
> > >  %post daemon-config-nwfilter
> > >  cp %{_datadir}/libvirt/nwfilter/*.xml %{_sysconfdir}/libvirt/nwfilter/
> > > +# libvirt saves these files with mode 600
> > > +chmod 600 %{_sysconfdir}/libvirt/nwfilter/*.xml
> > >  # Make sure libvirt picks up the new nwfilter defininitons
> > >  mkdir -p %{_localstatedir}/lib/rpm-state/libvirt || :
> > >  touch %{_localstatedir}/lib/rpm-state/libvirt/restart || :
> > 
> > Interesting, I have the very same hunk in a larger patch that I'm
> > working on :)
> > 
> > The change itself looks good, but shouldn't you be able to remove
> > the corresponding call from the %install section at the same time?
> > It's not like it's doing anything useful at the moment anyway.
> 
> No, it's making sure the RPM database will have the right info in it.
> That is, if you remove the part in %install, RPM will record 644 for the
> XML files and the verification will always fail afterwards.

I was not convinced this would be the case but after playing around
and understanding the %ghost directive better, I agree that we also
need to keep those lines in, so

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list