[libvirt] [PATCH 4/8] lxc: Remove unnecessary comment

John Ferlan jferlan at redhat.com
Sun Nov 3 13:53:36 UTC 2019


Commit 66e2adb2ba moved the code and the coverity comment which now
was useless since the context was in lxcContainerSetupPivotRoot.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/lxc/lxc_container.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
index a18b214a25..1fb9049c96 100644
--- a/src/lxc/lxc_container.c
+++ b/src/lxc/lxc_container.c
@@ -1658,11 +1658,6 @@ static int lxcContainerUnmountForSharedRoot(const char *stateDir,
     /* Some versions of Linux kernel don't let you overmount
      * the selinux filesystem, so make sure we kill it first
      */
-    /* Filed coverity bug for false positive 'USE_AFTER_FREE' due to swap
-     * of root->src with root->dst and the VIR_FREE(root->src) prior to the
-     * reset of root->src in lxcContainerPrepareRoot()
-     */
-    /* coverity[deref_arg] */
     if (lxcContainerUnmountSubtree(SELINUX_MOUNT, false) < 0)
         goto cleanup;
 #endif
-- 
2.20.1




More information about the libvir-list mailing list