[libvirt] [PATCH RFC 32/40] backup: Parse and output backup XML

Eric Blake eblake at redhat.com
Thu Nov 7 23:20:59 UTC 2019


On 10/18/19 11:11 AM, Peter Krempa wrote:
> From: Eric Blake <eblake at redhat.com>
> 
> Accept XML describing a generic block job, and output it again as
> needed. This may still need a few tweaks to match the documented XML
> and RNG schema.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---

I didn't closely review for what types of changes you may have made to 
my original patch. I know some are inevitable, like rebasing to use 
glib.  But you may want to add your S-o-b and/or mention in the commit 
message what you've added, if it is non-trivial.

At any rate, I can't really add my own ACK to a patch I first wrote ;)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list