[libvirt] [PATCH v3 06/20] po: generate files into build directory

[Andrea Bolognani]

On Fri, 2019-11-08 at 10:04 +0000, Daniel P. Berrangé wrote:
> On Thu, Oct 24, 2019 at 03:05:24PM +0200, Pavel Hrdina wrote:
> > -endif HAVE_GNU_GETTEXT_TOOLS
> > -
> >  if ENABLE_NLS
> >  
> >  # Cannot use 'localedir' since this conflicts with autoconf.
> > @@ -99,7 +104,7 @@ install-data-hook: $(GMOFILES)
> >  	for lang in $(LANGS); do \
> >  	  d=$(DESTDIR)$(langinstdir)/$$lang/LC_MESSAGES; \
> >  	  mkdir -p $$d; \
> > -	  install -m 0644 $(srcdir)/$$lang.gmo $$d/$(DOMAIN).mo; \
> > +	  install -m 0644 $$lang.gmo $$d/$(DOMAIN).mo; \
> >  	done
> >  
> >  uninstall-hook:
> > @@ -109,3 +114,5 @@ uninstall-hook:
> >  	done
> >  
> >  endif ENABLE_NLS
> > +
> > +endif HAVE_GNU_GETTEXT_TOOLS
> 
> Moving this HAVE_GNU_GETTEXT_TOOLS conditional means that on OS that
> lack the GNU gettext impl, we are no longer able to 'make install'
> the translation files, despite having them prebuilt & bundled in the
> tarball.
> 
> IIRC, this affects any non-Linux host.

We install GNU gettext both on FreeBSD and on macOS, so it shouldn't
really be a problem I think? To me it doesn't seem much different
from mandating the use of GNU make, which we already do.

-- 
Andrea Bolognani / Red Hat / Virtualization