[libvirt] [PATCH 2/8] conf: Remove ATTRIBUTE_NONNULL for virDomainQemuMonitorEventNew

Ján Tomko jtomko at redhat.com
Mon Nov 11 12:10:26 UTC 2019

On Sun, Nov 03, 2019 at 08:53:34AM -0500, John Ferlan wrote:
>Commit 17561eb36 modified the logic to check "if (!event)" for an
>attribute that was not supposed to be passed as NULL.  This causes
>the static checker/Coverity build to fail. Since the check is made,
>alter the header.

Oops, I forgot to push this already acked patch that removed the condition


>Also add an error message since returning -1 without some sort of
>error message as previously would have happened with the failed
>VIR_STRDUP so that the eventual error doesn't get the default
>for some reason message.
>Signed-off-by: John Ferlan <jferlan at redhat.com>
> src/conf/domain_event.c | 6 +++++-
> src/conf/domain_event.h | 2 +-
> 2 files changed, 6 insertions(+), 2 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191111/f52b339c/attachment-0001.sig>

More information about the libvir-list mailing list