[libvirt] [PATCH 0/2] First round of out-of-tree build fixes

Michal Privoznik mprivozn at redhat.com
Mon Nov 11 13:22:19 UTC 2019


Some low hanging fruit here.

There are more serious issues that I yet have to figure out:
1) docs/ is broken. Just open any site from your build directory. Our
main.js lives in the source dir but we are trying to load it relative to
build dir

2) Generation of acl.html is broken - it assumes aclperms.htmlinc file
lives under $srcdir which is not true anymore => page that's generated
is useless

3) I've tried to update Gentoo live ebuild, but it failed to compile:

Making all in src
make[2]: Entering directory '/var/tmp/portage/app-emulation/libvirt-9999/work/libvirt-9999_build/src'
...
/usr/bin/perl /var/tmp/portage/app-emulation/libvirt-9999/work/libvirt-9999/src/access/genpolkit.pl < /var/tmp/portage/app-emulation/libvirt-9999/work/libvirt-9999/src/access/viraccessperm.h > access/org.libvirt.api.policy || rm -f access/org.libvirt.api.policy
/usr/bin/perl -w /var/tmp/portage/app-emulation/libvirt-9999/work/libvirt-9999/src/rpc/gendispatch.pl --mode=aclheader \
  remote REMOTE /var/tmp/portage/app-emulation/libvirt-9999/work/libvirt-9999/src/remote/remote_protocol.x \
  > access/viraccessapicheck.h
/bin/sh: access/org.libvirt.api.policy: No such file or directory

The libvirt-9999_build/src/access dir doesn't exist (I'm surprised it
wasn't created automatically by autotools since src/ was). I'll have to
investigate further.


Michal Prívozník (2):
  src: Make check-aclrules work again
  make check-driverimpls work again

 src/Makefile.am                 | 7 ++-----
 src/bhyve/Makefile.inc.am       | 4 ++--
 src/esx/Makefile.inc.am         | 2 +-
 src/hyperv/Makefile.inc.am      | 2 +-
 src/interface/Makefile.inc.am   | 4 ++--
 src/libxl/Makefile.inc.am       | 4 ++--
 src/lxc/Makefile.inc.am         | 4 ++--
 src/network/Makefile.inc.am     | 4 ++--
 src/node_device/Makefile.inc.am | 8 ++++----
 src/nwfilter/Makefile.inc.am    | 4 ++--
 src/openvz/Makefile.inc.am      | 2 +-
 src/phyp/Makefile.inc.am        | 2 +-
 src/qemu/Makefile.inc.am        | 4 ++--
 src/remote/Makefile.inc.am      | 2 +-
 src/secret/Makefile.inc.am      | 4 ++--
 src/storage/Makefile.inc.am     | 4 ++--
 src/test/Makefile.inc.am        | 2 +-
 src/vbox/Makefile.inc.am        | 4 ++--
 src/vmware/Makefile.inc.am      | 2 +-
 src/vz/Makefile.inc.am          | 4 ++--
 20 files changed, 35 insertions(+), 38 deletions(-)

-- 
2.23.0




More information about the libvir-list mailing list