[libvirt] [PATCH] qemu: Warn verbosely if using old loader:nvram pairs

[Daniel P. Berrangé]

On Mon, Nov 11, 2019 at 05:42:17PM +0100, Michal Privoznik wrote:
> There are two ways for specifying loader:nvram pairs:
> 
>   1) --with-loader-nvram configure option
>   2) nvram variable in qemu.conf
> 
> Since we have FW descriptors, using this old style is
> discouraged, but not as strong as one would expect. Produce more
> warnings:
> 
>   1) produce a warning if somebody tries the configure option
>   2) produce a warning if somebody sets nvram variable and at
>      least on FW descriptor was found
> 
> The reason for producing warning in case 1) is that package
> maintainers, who set the configure option in the first place
> should start moving towards FW descriptors and abandon the
> configure option. After all, the warning is printed into config
> output only in this case.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1763477
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  m4/virt-loader-nvram.m4 | 10 +++++++++-
>  src/qemu/qemu.conf      |  3 +++
>  src/qemu/qemu_conf.c    | 19 +++++++++++++++++--
>  3 files changed, 29 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|