[libvirt] [PATCH] qemu: command: Use XML based disk bus convertor in error message

[Eric Blake]

On 11/11/19 9:56 AM, Peter Krempa wrote:
> The qemu driver has an internal implementation for converting disk bus
> to string for use with qemu. This should not be used in error messages
> though as we want to report the string based on the XML value.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_command.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

ACK

> 
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index f37aecda37..3806cbbaf9 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -1303,7 +1303,7 @@ qemuCheckDiskConfig(virDomainDiskDefPtr disk,
>               disk->bus != VIR_DOMAIN_DISK_BUS_SCSI) {
>               virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>                              _("disk device='lun' is not supported for bus='%s'"),
> -                           virDomainDiskQEMUBusTypeToString(disk->bus));
> +                           virDomainDiskBusTypeToString(disk->bus));
>               return -1;
>           }
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org