[libvirt] [PATCH 0/8] Remove use of 'areadlink' gnulib module (kill-a-gnulib-module-a-day initiative)

Peter Krempa pkrempa at redhat.com
Wed Nov 13 13:07:01 UTC 2019


This removes use of 'areadlink' by using 'g_file_read_link' and fixes a
few insane uses.

Note that I'll post the actual module deletion from bootstrap.conf
separately as touching that file results in lengthy rebuilds.

Peter Krempa (8):
  qemu: domain: Use g_file_read_link instead of virFileReadLink
  util: file: Remove virFileReadLink
  qemu: tpm: Use g_autofree in qemuTPMEmulatorGetPid
  qemu: tpm: Sanitize error values in qemuTPMEmulatorGetPid
  qemu: gpu: Sanitize error values in qemuVhostUserGPUGetPid
  util: pidfile: Sanitize return values of virPidFileReadIfAlive
  util: pidfile: Sanitize return values of virPidFileReadPathIfAlive
  util: pidfile: Replace 'areadlink' by 'g_file_read_link'

 src/libvirt_private.syms       |  1 -
 src/qemu/qemu_domain.c         | 18 +++++-----
 src/qemu/qemu_tpm.c            | 16 ++++-----
 src/qemu/qemu_vhost_user_gpu.c | 12 ++++---
 src/util/virfile.c             | 13 -------
 src/util/virfile.h             |  3 --
 src/util/virpidfile.c          | 64 +++++++++++++++++-----------------
 7 files changed, 56 insertions(+), 71 deletions(-)

-- 
2.23.0




More information about the libvir-list mailing list