[libvirt] [PATCH 0/8] Remove use of 'areadlink' gnulib module (kill-a-gnulib-module-a-day initiative)

Ján Tomko jtomko at redhat.com
Thu Nov 14 11:35:30 UTC 2019


On Wed, Nov 13, 2019 at 02:07:01PM +0100, Peter Krempa wrote:
>This removes use of 'areadlink' by using 'g_file_read_link' and fixes a
>few insane uses.
>
>Note that I'll post the actual module deletion from bootstrap.conf
>separately as touching that file results in lengthy rebuilds.
>
>Peter Krempa (8):
>  qemu: domain: Use g_file_read_link instead of virFileReadLink
>  util: file: Remove virFileReadLink
>  qemu: tpm: Use g_autofree in qemuTPMEmulatorGetPid
>  qemu: tpm: Sanitize error values in qemuTPMEmulatorGetPid
>  qemu: gpu: Sanitize error values in qemuVhostUserGPUGetPid
>  util: pidfile: Sanitize return values of virPidFileReadIfAlive
>  util: pidfile: Sanitize return values of virPidFileReadPathIfAlive
>  util: pidfile: Replace 'areadlink' by 'g_file_read_link'
>
> src/libvirt_private.syms       |  1 -
> src/qemu/qemu_domain.c         | 18 +++++-----
> src/qemu/qemu_tpm.c            | 16 ++++-----
> src/qemu/qemu_vhost_user_gpu.c | 12 ++++---
> src/util/virfile.c             | 13 -------
> src/util/virfile.h             |  3 --
> src/util/virpidfile.c          | 64 +++++++++++++++++-----------------
> 7 files changed, 56 insertions(+), 71 deletions(-)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191114/8b1039bd/attachment-0001.sig>


More information about the libvir-list mailing list