[libvirt] [PATCH 3/3] syntax-check: prefer g_mkstemp_full and g_mkdtemp

Ján Tomko jtomko at redhat.com
Thu Nov 14 13:48:06 UTC 2019


Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 build-aux/syntax-check.mk | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 74d0d5f6d4..7d1ac4dbfc 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -402,10 +402,17 @@ sc_prohibit_fork_wrappers:
 	halt='use virCommand for child processes' \
 	  $(_sc_search_regexp)
 
-# Prefer mkostemp with O_CLOEXEC.
+# Prefer g_mkostemp_full with O_CLOEXEC.
 sc_prohibit_mkstemp:
-	@prohibit='[^"]\<mkstemps? *\(' \
-	halt='use mkostemp with O_CLOEXEC instead of mkstemp' \
+	@prohibit='[^"]\<mko?stemps? *\(' \
+	in_vc_files='\.[chx]$$' \
+	halt='use g_mkstemp_full with O_CLOEXEC instead of mkstemp' \
+	  $(_sc_search_regexp)
+
+sc_prohibit_mkdtemp:
+	@prohibit='[^"]\<mkdtemp *\(' \
+	in_vc_files='\.[chx]$$' \
+	halt='use g_mkdtemp instead of mkdtemp' \
 	  $(_sc_search_regexp)
 
 # access with X_OK accepts directories, but we can't exec() those.
-- 
2.21.0




More information about the libvir-list mailing list