[libvirt] [PATCH v4 0/7] Fix virConnectRegisterCloseCallback and get rid of global variables

Marc Hartmayer mhartmay at linux.ibm.com
Thu Nov 14 17:44:18 UTC 2019


The second patch of this patch series fixes the behavior of
virConnectRegisterCloseCallback.

The subsequent patches remove the need to have the global variables
'qemuProgram' and 'remoteProgram' in libvirtd.[ch]. They only work in
combination with the fixed behavior of
virConnectRegisterCloseCallback.

Changelog:
 + v3->v4:
   - Rebased to current master
   - Added Pavel's r-bs
   - Worked in Pavel's comments
   - Added patch "remote: shrink the critical sections" in preparation
     for patch "remote/rpc: Use virNetServerGetProgram() to determine
     the program"
 + v2->v3:
   - Rebased to current master
   - Added Johns r-b to the first patch, all other r-b's I have
     dropped as there were to many changes in the meantime
   - Removed accepted patches
   - Dropped patches 8 and 9
 + v1->v2:
   - Removed accepted patches
   - Removed NACKed patches
   - Added r-b to patch 5
   - Worked in comments
   - Rebased
   - Added patches 7-9

Marc Hartmayer (7):
  rpc: use the return value of virObjectRef directly
  virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no
    connectRegisterCloseCallback
  remote: Save reference to program in daemonClientEventCallback
  remote: Use domainClientEventCallbacks for
    remoteReplayConnectionClosedEvent
  rpc: Introduce virNetServerGetProgramLocked helper function
  remote: shrink the critical sections
  remote/rpc: Use virNetServerGetProgram() to determine the program

 src/libvirt-host.c                  |  16 +-
 src/libvirt_remote.syms             |   1 +
 src/remote/remote_daemon.c          |   4 +-
 src/remote/remote_daemon.h          |   2 -
 src/remote/remote_daemon_dispatch.c | 363 +++++++++++++++++-----------
 src/rpc/gendispatch.pl              |   6 +
 src/rpc/virnetserver.c              |  53 +++-
 src/rpc/virnetserver.h              |   2 +
 8 files changed, 293 insertions(+), 154 deletions(-)

-- 
2.21.0





More information about the libvir-list mailing list