[libvirt] [PATCH v3 0/4] Fix up some issues from x and y resolution patches

Cole Robinson crobinso at redhat.com
Fri Nov 15 18:54:16 UTC 2019

On 11/14/19 4:59 PM, Jonathon Jongsma wrote:
> This is the third version of this patch series after a review from Cole. The
> main changes to this version of the patch series are:
>  - several patches have been pushed upstream (and therefore dropped from this
>    series
>  - The iteration over child nodes was moved up to the caller due to a
>    suggestion from Cole (much better, thanks)
>  - Because the parse functions are now only called when the appropriate XML
>    element is present, the parse functions no longer need to return
>    "successful" NULL for the case where the element is not specified in the
>    XML. Therefore we do not need to change the function signatures and we can
>    simply treat a NULL return value as an error.
>  - the resolution validation is moved to virDomainVideoDefValidate().
> Jonathon Jongsma (4):
>   conf: iterate video model children in parent function
>   conf: report errors when parsing video resolution
>   conf: report errors when parsing video acceleration
>   conf: validate video resolution
>  src/conf/domain_conf.c | 75 ++++++++++++++++++++++--------------------
>  1 file changed, 40 insertions(+), 35 deletions(-)

Reviewed-by: Cole Robinson <crobinso at redhat.com>

And pushed

- Cole

More information about the libvir-list mailing list