[libvirt] [PATCH v5 04/23] build-aux: rewrite header ifdef checker in Python

Cole Robinson crobinso at redhat.com
Fri Nov 15 20:35:59 UTC 2019


On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the header-ifdef.pl tool in Python.
> 
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
> of the file and approach is the same.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  Makefile.am               |   2 +-
>  build-aux/header-ifdef.pl | 182 ------------------------------
>  build-aux/syntax-check.mk |   4 +-
>  scripts/header-ifdef.py   | 231 ++++++++++++++++++++++++++++++++++++++
>  4 files changed, 234 insertions(+), 185 deletions(-)
>  delete mode 100644 build-aux/header-ifdef.pl
>  create mode 100644 scripts/header-ifdef.py

I verified it catches all 3 errors described in the top comment

Tested-by: Cole Robinson <crobinso at redhat.com>

- Cole




More information about the libvir-list mailing list