[libvirt] [PATCH v5 06/23] src: rewrite symfile sorting checker in Python

Cole Robinson crobinso at redhat.com
Fri Nov 15 20:46:25 UTC 2019


On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the check-symsorting.pl tool in Python.
> 
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
> of the file and approach is the same.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  Makefile.am                 |   1 +
>  scripts/check-symsorting.py | 117 ++++++++++++++++++++++++++++++++++++
>  src/Makefile.am             |   4 +-
>  src/admin/Makefile.inc.am   |   2 +-
>  src/check-symsorting.pl     | 106 --------------------------------
>  5 files changed, 121 insertions(+), 109 deletions(-)
>  create mode 100755 scripts/check-symsorting.py
>  delete mode 100755 src/check-symsorting.pl

I verified this catches out of order libvirt_private.syms

Tested-by: Cole Robinson <crobinso at redhat.com>

- Cole




More information about the libvir-list mailing list