[libvirt] [PATCH 3/3] network: Check for QOS before blindly using it

Daniel Henrique Barboza danielhb413 at gmail.com
Mon Nov 18 13:19:43 UTC 2019

On 11/14/19 6:58 PM, John Ferlan wrote:
> If networkAllocatePort calls networkPlugBandwidth eventually the
> port->bandwidth would be passed to virNetDevBandwidthPlug which
> requires that the parameter is non-NULL.  Coverity additionally
> notes that since (!port->bandwidth) is checked earlier in the
> networkAllocatePort method that the subsequent call to blindly
> use if for a function that requires it needs to check.
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>   src/network/bridge_driver.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)

Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

More information about the libvir-list mailing list