[libvirt] [PATCH v5 00/23] scripts: convert most perl scripts to python

[Daniel P. Berrangé]

On Fri, Nov 15, 2019 at 03:07:32PM -0500, Cole Robinson wrote:
> On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> > This series is an effort to reduce the number of different
> > languages we use by eliminating most use of perl in favour
> > of python.
> 
> I'm testing the series now. On fedora 31, make syntax-check is showing
> some flake8 errors, see attached. I also attach a run of pycodestyle and
> pylint using my standard configs. There's nothing that looks like a
> legitimate bug in any of the output, though I didn't look too closely at
> the overridden variable warnings

The obvious errors here these ones:

> scripts/check-aclrules.py:174:34: E1305: Too many arguments for format string (too-many-format-args)
> scripts/check-aclrules.py:193:34: E1305: Too many arguments for format string (too-many-format-args)
> scripts/check-aclrules.py:228:34: E1305: Too many arguments for format string (too-many-format-args)
> scripts/check-aclrules.py:235:34: E1305: Too many arguments for format string (too-many-format-args)

> scripts/check-driverimpls.py:57:34: E1305: Too many arguments for format string (too-many-format-args)
> scripts/check-driverimpls.py:80:30: E1305: Too many arguments for format string (too-many-format-args)

> scripts/hvsupport.py:130:36: E1305: Too many arguments for format string (too-many-format-args)

all were in exception formatting where we broke the message across
lines - % binds more strongly than +

So

   "foo %s bar" +
   "wizz" % "eek"

Needs to be

   ("foo %s bar" +
    "wizz") % "eek"



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|