[libvirt] [PATCH v5 13/23] src: rewrite polkit ACL generator in Python

Cole Robinson crobinso at redhat.com
Mon Nov 18 18:49:10 UTC 2019


On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the genpolkit.pl tool in Python.
> 
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
> of the file and approach is the same.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  Makefile.am                |   1 +
>  scripts/genpolkit.py       | 122 +++++++++++++++++++++++++++++++++++++
>  src/access/Makefile.inc.am |   6 +-
>  src/access/genpolkit.pl    | 119 ------------------------------------
>  4 files changed, 126 insertions(+), 122 deletions(-)
>  create mode 100755 scripts/genpolkit.py
>  delete mode 100755 src/access/genpolkit.pl
> 

Generates identical org.libvirt.api.policy for me

Tested-by: Cole Robinson <crobinso at redhat.com>

- Cole




More information about the libvir-list mailing list