[libvirt] [PATCH v5 15/23] tests: rewrite test argv line wrapper in Python

Cole Robinson crobinso at redhat.com
Mon Nov 18 19:01:02 UTC 2019


On 11/11/19 9:38 AM, Daniel P. Berrangé wrote:
> As part of an goal to eliminate Perl from libvirt build tools,
> rewrite the test-wrap-argv.pl tool in Python.
> 
> This was a straight conversion, manually going line-by-line to
> change the syntax from Perl to Python. Thus the overall structure
> of the file and approach is the same.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  Makefile.am               |   1 +
>  build-aux/syntax-check.mk |   4 +-
>  scripts/test-wrap-argv.py | 170 +++++++++++++++++++++++++++++++++++++
>  tests/test-wrap-argv.pl   | 174 --------------------------------------
>  tests/testutils.c         |  16 ++--
>  5 files changed, 181 insertions(+), 184 deletions(-)
>  create mode 100755 scripts/test-wrap-argv.py
>  delete mode 100755 tests/test-wrap-argv.pl
> 

./scripts/test-wrap-argv.py --in-place tests/qemuxml2argvdata/*.args

isn't idempotent, it adds trailing whitespace, but I didn't investigate.
The perl script doesn't alter those files

- Cole




More information about the libvir-list mailing list